Jump to content

Wikipedia talk:Twinkle

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

This is an old revision of this page, as edited by Amorymeltzer (talk | contribs) at 11:24, 16 December 2020 (→‎Tag redirect: Bug! Fixed.). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.

Odd bug?

Hey all, I can't tell if this is a Twinkle bug or something different. I tried issuing a vandalism warning to this guy twice. I'm linking to what was on his talk page when I tried to warn him. The warning didn't go through, twice, and just sort of hung there as if it was waiting to process. When I deleted the non-existent template from his talk page, I was then able to process the warning. Cyphoidbomb (talk) 23:35, 24 November 2020 (UTC)[reply]

Sorry Cyphoidbomb, just saw this, but same issue as below and should be fixed! ~ Amory (utc) 11:50, 26 November 2020 (UTC)[reply]

Fails to issue warning

I have tried several times to issue a warning on the Sandbox for user warnings page, but failed to do so. A message box containing the text "User talk page modification: Retrieving page..." appears and forever hangs it there with no subsequent results. Mosesheron (talk) 13:43, 25 November 2020 (UTC)[reply]

Bug! Fixed! Thanks for the report. ~ Amory (utc) 11:49, 26 November 2020 (UTC)[reply]

Watchlist expiry default options

I've just pushed some code that should enable the new watchlist expiry coming next week. What I wanted to ask, however, was whether or not some of the defaults should change. Here are the current unchanged defaults:

  • ARV: Add sockpuppet report pages to watchlist (indefinitely)
  • Image: Add image page to watchlist when tagging (follow site preferences)
  • Image: Add user talk page of initial uploader to watchlist when notifying (follow site preferences)
  • PROD: Add article to watchlist when tagging (indefinitely)
  • Rollback/revert: When reverting a page, how long to watch it for (indefinitely)
  • CSD: When tagging a page, how long to watch it for (indefinitely)
  • Tag: Add page to watchlist when tagging (indefinitely)
  • Tag: Add talk pages to watchlist when starting merge discussions (indefinitely)
  • Warn: Add user talk page to watchlist when notifying (indefinitely)
  • Welcome: Add user talk pages to watchlist when welcoming (indefinitely)
  • XFD: Add the nominated page to watchlist (follow site preferences)
  • XFD: Add the deletion discussion page to watchlist (follow site preferences)
  • XFD: Add the daily log/list page to the watchlist (where applicable) (no)
  • XFD: Add user talk page of initial contributor to watchlist (when notifying) (follow site preferences)
  • XFD: Add the redirect's target page to watchlist (when notifying) (follow site preferences)

At the moment, Twinkle will use expiry options of 1 week, 1 month, 3 months, and 6 months. Should any of these be changed to one of those values? In particular I can see PROD, XfD, and CSD making liberal use of them, but what do people think? ~ Amory (utc) 19:15, 28 November 2020 (UTC)[reply]

There's also a suggestion I've made to add options to the rpp/pp module to watch requested pages, watch tagged pages, and (for sysops) watch protected pages. What would folks think those should be set to? ~ Amory (utc) 19:30, 28 November 2020 (UTC)[reply]
I would probably favor 1 month for XFDs, maybe 1 month for PROD and delayed CSDs, and 1 week for immediate CSDs. I think these maximize the likelihood someone will see a relisting or recreation. I'm not sure if the split on CSDs is practical.
For page protections, it would be cool for the default watch time to be protection length + a week or something.
These thoughts might be generalized to: "watch until a week or so after when follow-up activity is most-likely to occur". --Izno (talk) 19:51, 28 November 2020 (UTC)[reply]
The CSD split is, indeed, not practical, but 1 month for all ain't gonna hurt much. 1 month/1 month/1 week was roughly what I figured, but you've a good point on the delayed ones. I'm intrigued by your idea for protections, maybe I'll mull that down the line. Of course, indefinite protections are least likely to need indefinite watching... ~ Amory (utc) 20:48, 30 November 2020 (UTC)[reply]
I've suggested that editors be allowed to change their default expiry periods in general. (We currently have only "add forever" and "don't add".) Any solution for Twinkle might bear in mind the possibility of something like this being implemented. Certes (talk) 20:11, 28 November 2020 (UTC)[reply]
As a user, I'd expect "follow site preferences" to do just that. Might require work down the line, but will cross that bridge if/when we get there. ~ Amory (utc) 20:49, 30 November 2020 (UTC)[reply]
So would I. The problem is that the site preference can only be set to "don't watch" or "forever", and there are no plans to change that (it was omitted from the implementation that's about to be rolled out). Certes (talk) 21:43, 30 November 2020 (UTC)[reply]
I can't decide whether vandal reverters would prefer a shorter default watch period for rollback/revert... ~ Amory (utc) 20:51, 30 November 2020 (UTC)[reply]

Headsup: there is an discussion about merging uw-vandalism1 into uw-disruptive1

Just as a quick headsup since the author appears to have forgotten to do so, there is an ongoing discussion at TFD about merging uw-vandalism1 into uw-disruptive1. Merry Christmas! Asartea Talk Contribs! 14:23, 3 December 2020 (UTC)[reply]

Change request: BLPPROD should not put Template:old prod on talk page

That template is to alert editors that the page is no longer eligible for a regular PROD.

Think of BLPPROD as a special case of "slow speedy deletion" similar to the "7 day speedy deletions" for files on the Commons. It's "speedy" because there is no discussion - at the end of 7 days either the page lacks a reference and it will be deleted, or there is a reference and someone forgot to remove the template. davidwr/(talk)/(contribs) 23:01, 5 December 2020 (UTC)[reply]

Temporary watchlisting behaviour

I'm trying out the new watchlist expiry options, so that if I use Twinkle to revert vandalism on some random article it is watchlisted for 90 days instead of forever. This is great, and should stop my watchlist growing without limit. However, I notice today that if I've previously chosen to watchlist a page indefinitely and then use Twinkle to revert vandalism there, the watchlisting is reduced to 90 days. I would prefer that this didn't happen. -- John of Reading (talk) 10:11, 7 December 2020 (UTC)[reply]

I absolutely agree. I've got some fixes up coming up in the queue (tomorrow?) as well as a larger rejiggering (PR 1242 if folks care), but it basically requires an extra query to do properly, and even then it's not quite perfect. But yes, this will be fixed soon. ~ Amory (utc) 21:29, 13 December 2020 (UTC)[reply]

Tag redirect

Not sure if I did something wrong, but I tried to tag a redirect using Twinkle and it messed up by the looks of it. Here are the last three diffs: 3) Before 2) Twinkle 1) Manual Fix. Just asking here to confirm (or not) this is a bug before filing one at github. Feelthhis (talk) 04:17, 16 December 2020 (UTC)[reply]

I'm not sure if it's a bug or not, but the error is caused by the optional "|1=" parameter in Template:Redirect category shell, which Twinkle apparently doesn't recognize. BilCat (talk) 06:42, 16 December 2020 (UTC)[reply]
Yup, that looks like exactly it. Thanks for the report Feelthhis, I've pushed up a fix in the regex that should take care of it, might take a few minutes to go through. ~ Amory (utc) 11:24, 16 December 2020 (UTC)[reply]

December 2020 Twinkle updates (2020-12-16)

Some good quality of life improvements this time around! Support for expiring watchlists was already available, but some kinks have been ironed out and improved to make it more useful. There are also some new watchlist preferences for the tag and page protection modules, allowing you to choose which types of pages to watch. CSD and XfD will both handle talk pages and non-wikitext pages better, and the protect and block modules now show more information. There are a number of other improvements and bug fixes are present as well; a brief summary of some of the more notable items are below. Changes not otherwise attributed were made by User:Amorymeltzer.

  • Watchlist expiry:
    • Supported for all watchlist options in your Twinkle preferences
      • Options are: 1 week, 1 month, 3 months, and 6 months
    • Indefinitely watched pages will not be converted to an expiry
    • No defaults have been changed, but see the section above if you think they should.
  • xfd:
    • Don't try to add edit request if page is already a talk (#1211)
    • Notify WT:TW/WT:AWB/WT:REDWARN automatically on TfD nomination (#1243, by Mdaniels5757)
    • Better handle content models for tfd and mfd nominations (#1208)
    • Fix RfD target page notifications for userspace nominations (#1232, by SD0001)
    • Adjust portlet tooltip to be more accurate for likely venue (#1193)
  • tag:
  • speedy:
    • Tag talkpage if unable to edit page (#1208)
    • Better handle content models when tagging (#1208)
  • arv:
    • AN3: Don't follow redirects; always show resolution free entry field (#1195)
    • Note and soften message if user is already blocked (#1204)
  • protect: Add options for watching protected/requested/tagged pages (#1133)
  • protect/block: Show expiration of or timestamp for last action (if not currently restricted) (#1194)
  • block: Add Horn of Africa DS topic (#1231)
  • warn: Add {{uw-notenglishedit}} (#1196, by TheTVExpert)

This section should serve as a catching ground should anything not work properly or if any new bugs crop up, as well as for any feedback or suggestions. There were a lot of changes behind the scenes, so feel free to ping me. As always, input is welcome at the GitHub repo as well. Finally, if you're interested in helping out with Twinkle development, there's a helpful guideline for new contributors — check it out! ~ Amory (utc) 11:00, 16 December 2020 (UTC)[reply]

Technical changes

We now have jsdocs for the Morebits library (#1190)! You can check them out at https://azatoth.github.io/twinkle/. There have been a lot of background changes to Twinkle and Morebits lately, an overview of changes to the morebits library for interested developers:

  • Added unit tests for many functions (#1213)
  • Enforce newer API error message format, defaulting to html (#1179)
  • All Morebits and Twinkle uses of Morebits.wiki.api now use json rather than xml (#1224).
  • Force loading of a page if a watchlist expiry is provided (#1242)
  • userspaceLogger returns a promise (#1234, by SD0001)
  • Morebits.status: Teach codify to parse HTML for status messages (#1179)
  • Morebits: Add YYYYMMDDHHmmss format to Morebits.date constructor (#1200)
  • Many fixes and improvements to Morebits.wikitext methods (#1240, #1239, #1214, #1225), and #1225)

~ Amory (utc) 11:00, 16 December 2020 (UTC)[reply]