Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] struct Parrot_Context doesn't need a 'prev' field.

0 views
Skip to first unread message

Bob Rogers

unread,
Jan 14, 2006, 3:28:21 PM1/14/06
to parr...@parrotcode.org, p6i
I had thought this field was being used, but it turns out to be
irrelevant. I offer this patch so that no one else is fooled (and
because I had to test it anyway to prove that this is the case).

-- Bob Rogers
http://rgrjr.dyndns.org/

rename-context-prev.patch

Leopold Toetsch

unread,
Jan 15, 2006, 2:34:30 PM1/15/06
to Bob Rogers, parr...@parrotcode.org, p6i

On Jan 14, 2006, at 21:28, Bob Rogers wrote:

> I had thought this field was being used, but it turns out to be
> irrelevant. I offer this patch so that no one else is fooled (and
> because I had to test it anyway to prove that this is the case).

Thanks, applied - r11199

leo

Matt Fowles

unread,
Jan 17, 2006, 4:29:55 PM1/17/06
to Leopold Toetsch, Bob Rogers, parr...@parrotcode.org, p6i
Bob~

Why leave it in as a placeholder at all?

Matt
--
"Computer Science is merely the post-Turing Decline of Formal Systems Theory."
-Stan Kelly-Bootle, The Devil's DP Dictionary

Bob Rogers

unread,
Jan 17, 2006, 9:26:57 PM1/17/06
to Matt Fowles, Leopold Toetsch, parr...@parrotcode.org, p6i
From: Matt Fowles <uber...@gmail.com>
Date: Tue, 17 Jan 2006 16:29:55 -0500

Bob~

On 1/15/06, Leopold Toetsch <l...@toetsch.at> wrote:
>
> On Jan 14, 2006, at 21:28, Bob Rogers wrote:
>
> > I had thought this field was being used, but it turns out to be
> > irrelevant. I offer this patch so that no one else is fooled (and
> > because I had to test it anyway to prove that this is the case).
>
> Thanks, applied - r11199

Why leave it in as a placeholder at all?

Matt

Good question. I did so because of the "common header with
Interp_Context" comment in struct Parrot_Context. It didn't seem to be
vestigial, and in any case I wasn't sure how to test that, so I left it
alone.

-- Bob

Leopold Toetsch

unread,
Jan 18, 2006, 7:48:03 AM1/18/06
to p6i
Bob Rogers wrote:
> From: Matt Fowles <uber...@gmail.com>

>
> Why leave it in as a placeholder at all?
>
> Matt
>
> Good question. I did so because of the "common header with
> Interp_Context" comment in struct Parrot_Context.

Yep. And this common header is actually used in e.g.
mark_register_stack. But we could move e.g. C<caller_ctx> there and safe
one word of context space.

leo

0 new messages