[perl #38216] [PATCH] fix parrot.pc.in
Greg Bacon
# Please include the string: [perl #38216]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=38216 >
There appears to have been some slop in the ${foo} -> @foo@ change,
and the attached patch fixes it.
Also, did libdir and includedir change to include underscores?
Greg
Nick Glencross
Hi Greg,
The parrot.pc.in has suffered a bit, hasn't it.
What I originally did with the parrot.pc.in was retain the general style
of other pkg-config configuration files, such as:
prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
Name: GTK+
Description: GIMP Tool Kit
Version: 1.2.10
Requires: gdk
Libs: -L${libdir} -lgtk
Cflags:
It looks like only prefix is actually set, and the other paths are set
using pkgconfig variables (which look the same as the style that we've
just moved away from).
I hope that you don't mind, but I've not used your patch per se, but
have fixed the problem in r11128 similarly. Before closing the call, it
might be worth checking with everyone that libdir/includedir will always
be correct, otherwise we'll expand their paths.
Thanks for spotting,
Nick
Joshua Hoblitt
> It looks like only prefix is actually set, and the other paths are set
> using pkgconfig variables (which look the same as the style that we've
> just moved away from).
>
> I hope that you don't mind, but I've not used your patch per se, but
> have fixed the problem in r11128 similarly. Before closing the call, it
> might be worth checking with everyone that libdir/includedir will always
> be correct, otherwise we'll expand their paths.
DOH! I noticed that yesterday when I was editing parrot.pc.in and
decided that I should fix it as a separate changeset. Then promptly
forgot to fix it... nice catch.
-J
--