develooper Front page | perl.perl6.compiler | Postings from November 2004

Fwd: Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

From:
Patrick R. Michaud
Date:
November 19, 2004 15:39
Subject:
Fwd: Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)
Message ID:
20041119233934.GB27728@contra.vosn.net
Just a quick note to perl6-compilers that I've just committed
a patch (timely submitted by Andy Dougherty) that should enable 
p6ge to compile under OSX and a few other environments a bit 
more cleanly.  More details to come soon.

Pm


----- Forwarded message from "Patrick R. Michaud" <pmichaud@pobox.com> -----

Date: Fri, 19 Nov 2004 16:37:33 -0700
From: "Patrick R. Michaud" <pmichaud@pobox.com>
To: Andy Dougherty <doughera@lafayette.edu>
Cc: Perl6 Internals <perl6-internals@perl.org>
Subject: Re: [PATCH] Re: Getting the grammar engine in (or a small task for the interested)

On Fri, Nov 19, 2004 at 04:30:06PM -0500, Andy Dougherty wrote:
> 
> Ok, here's a first pass.  Most of it is pretty straightforward, but one
> thing is worth noting:
> 
> The code uses both signed and unsigned chars, with and without the 'const'
> qualifier.  I gather this is a deliberate part of a carefully considered
> overall design.  

You're being very kind, but no, it's an indication of my working too late 
one night.  It really should all be unsigned characters, and its fixed now,
as well as the bunches of warnings that gcc was giving when compiling
everything.

> Without understanding the underlying design, I don't know offhand what to
> recommend, but this patch works for me and highlights spots where some
> further thought might be needed.

Thanks a *bunch* for this -- I've gone ahead and applied the patches
(along with other cleanups) and committed them into CVS. 

A test suite harness for p6ge should be coming within the next day or so--
stay tuned.

Pm

----- End forwarded message -----



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About