[Configure.pl] do or die idiom fix

rakudo · Oct 9, 2009 · 1f2e5f4 · 1f2e5f4
1 parent daf221d
commit 1f2e5f4
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/Configure.pl b/Configure.pl
@@ -19,8 +19,8 @@
     }
 
     # Determine the revision of Parrot we require
-    open my $REQ, "build/PARROT_REVISION"
-      || die "cannot open build/PARROT_REVISION\n";
+    open my $REQ, '<', "build/PARROT_REVISION"
+      or die "cannot open build/PARROT_REVISION: $!\n";
     my ($reqsvn, $reqpar) = split(' ', <$REQ>);
     $reqsvn += 0;
     close $REQ;
@@ -143,10 +143,7 @@ sub verify_parrot {
         "$PARROT_INCLUDE_DIR",
         "$PARROT_INCLUDE_DIR/pmc",
     );
-    my @missing;
-    for my $reqfile (@required_files) {
-        push @missing, "    $reqfile" unless -e $reqfile;
-    }
+    my @missing = map { "    $_" } grep { ! -e } @required_files;
     if (@missing) {
         my $missing = join("\n", @missing);
         die <<"END";