Make implementation of EclectusBoolean closer to PhpBoolean

bschmalhofer · Mar 22, 2009 · ec5a767 · ec5a767
1 parent ce377c4
commit ec5a767
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 15 deletions.
diff --git a/src/pmc/eclectusboolean.pmc b/src/pmc/eclectusboolean.pmc
@@ -1,5 +1,4 @@
 /*
-Copyright (C) 2007, The Perl Foundation.
 
 =head1 NAME
 
@@ -18,20 +17,30 @@ boolean behavior.
 
 */
 
+
+
 pmclass EclectusBoolean
-    extends Boolean
-    does boolean
+    extends  Boolean
+    provides scalar
+    provides boolean
+    provides integer
     dynpmc
-    group eclectus_group
-    hll Eclectus
-    maps Boolean {
+    group    eclectus_group
+    hll      Eclectus
+    maps     Boolean {
 
-    STRING* get_string() {
-        return PMC_int_val(SELF) ?
-                   const_string(INTERP, "#t")
-                   :
-                   const_string(INTERP, "#f");
+=item C<STRING* get_string()>
+
+Return the string '1' or ''.
 
+=cut
+
+*/
+    STRING* get_string() {
+        if (SELF.get_integer())
+            return Parrot_str_new_constant(INTERP, "#t");
+        else
+            return Parrot_str_new_constant(INTERP, "#f");
     }
 }
 

diff --git a/t/pmc/boolean.t b/t/pmc/boolean.t
@@ -1,7 +1,3 @@
-#! ../../parrot
-# Copyright (C) 2008, The Perl Foundation.
-# $Id$
-
 =head1 NAME
 
 t/pmc/boolean.t - Boolean PMC
@@ -20,6 +16,7 @@ Tests C<EclectusBoolean> PMC.
     $P0 = loadlib "eclectus_group"
 
     .include "include/test_more.pir"
+
     plan(2)
 
     truth_tests()