Support namespacing with packages and inner classes

chrisdolan · Feb 20, 2009 · dc4fd26 · dc4fd26
1 parent 4c4df21
commit dc4fd26
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 18 deletions.
diff --git a/lib/Perk/Grammar.pm b/lib/Perk/Grammar.pm
@@ -65,7 +65,7 @@ rule compilationUnit {
 }
 
 rule packageDeclaration {
-    'package' <qualifiedName> ';'
+    'package' $<package>=[<qualifiedName>] ';' {*}
 }
 
 rule importDeclaration {
@@ -109,8 +109,9 @@ rule normalClassDeclaration {
     'class' <Identifier> <typeParameters>?
     ['extends' <type>]?
     ['implements' <typeList>]?
-    <classBody>
-    {*}
+    {*} #= start
+    <classBody>
+    {*} #= end
 }
 
 rule typeParameters {
@@ -175,7 +176,7 @@ rule classBodyDeclaration {
 
 rule memberDecl {
     | <genericMethodOrConstructorDecl>               {*} #= genericMethodOrConstructorDecl
-    | 'void' <Identifier> <voidMethodDeclaratorRest> {*} #= voidMethodDeclaratorRest
+    | 'void' <Identifier> <voidMethodDeclaratorRest> {*} #= voidMethodDeclaratorRest
     | <memberDeclaration>                            {*} #= memberDeclaration
     | <Identifier> <constructorDeclaratorRest>       {*} #= constructorDeclaratorRest
     | <interfaceDeclaration>                         {*} #= interfaceDeclaration
@@ -233,7 +234,7 @@ rule methodDeclaratorRest {
 
 rule voidMethodDeclaratorRest {
    <formalParameters> ['throws' <qualifiedNameList>]?
-        [ <methodBody> | ';' ]
+        [ <methodBody> | ';' ]
    {*}
 }
 
@@ -475,7 +476,7 @@ rule block {
    '{' <blockStatement>* '}' {*}
 }
 
-rule blockStatement {
+rule blockStatement {
     |   <localVariableDeclarationStatement> {*} #= localVariableDeclarationStatement
     |   <classOrInterfaceDeclaration>       {*} #= classOrInterfaceDeclaration
     |   <statement>                         {*} #= statement

diff --git a/lib/Perk/Grammar/Actions.pm b/lib/Perk/Grammar/Actions.pm
@@ -16,6 +16,9 @@ value of the comment is passed as the second argument to the method.
 
 class Perk::Grammar::Actions;
 
+our @package;
+our @classes;
+
 method TOP($/) {
    make $( $<compilationUnit> );
 }
@@ -36,7 +39,8 @@ method compilationUnit($/) {
 }
 
 method packageDeclaration($/) {
-   say('package');
+    my $package = ~$<package>;
+    @package = $package.split('.');
 }
 
 method annotation($/) {
@@ -99,17 +103,41 @@ method classDeclaration($/, $key) {
     make $( $/{$key} );
 }
 
-method normalClassDeclaration($/) {
-    my $class := $( $<classBody> );
-    $class.loadinit().push(
-        PAST::Op.new(
-            :pasttype('call'),
-            :name('!create_class'),
-            ~$<Identifier>
-        )
-    );
-    $class.namespace(~$<Identifier>);
-    make $class;
+method normalClassDeclaration($/, $key) {
+    if $key eq 'start' {
+        my @ns = self._compute_local_ns(~$<Identifier>);
+        @classes.push(@ns.join('.'));
+    } else {
+        @classes.pop;
+        my @ns = self._compute_local_ns(~$<Identifier>);
+        my $classname = @ns.join('.');
+        my $class := $( $<classBody> );
+        $class.loadinit().push(
+            PAST::Op.new(
+                :pasttype('call'),
+                :name('!create_class'),
+                $classname
+            )
+        );
+        $class.namespace(@ns);
+        make $class;
+    }
+}
+method _compute_local_ns(Str $name) {
+    my @ns;
+    if $name ~~ m/\./ {
+        # Fully qualified class
+        @ns = $name.split('.');
+    } elsif @classes.elems > 0 {
+        # Inner class
+        @ns = @classes[*-1].split('.');
+        @ns.push($name);
+    } else {
+        # Prepend package
+        @ns = @package;
+        @ns.push($name);
+    }
+    return @ns;
 }
 
 method classBody($/) {

diff --git a/t/com/example/Namespace.java b/t/com/example/Namespace.java
@@ -0,0 +1,10 @@
+package com.example;
+
+public class Namespace {
+
+   class Inner {
+   }
+
+   public static void main(String[] args) {
+   }
+}